Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update css-tree@^1.1.2 #5958

Merged
merged 1 commit into from
Feb 8, 2021
Merged

update css-tree@^1.1.2 #5958

merged 1 commit into from
Feb 8, 2021

Conversation

tanhauhau
Copy link
Member

Related #5876, unfortunately doesn't seemed to fix the error reported in #5876

Before submitting the PR, please make sure you do the following

- [x] Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@benmccann benmccann mentioned this pull request Feb 3, 2021
Closed
4 tasks
@Conduitry
Copy link
Member

It looks like this upgrade increases the size of compiler.js by 34-35k. (The compile is currently just under a megabyte now, so this would be an increase of 3.5%.) It might not be a very valuable goal to try to keep this size down, but I do feel a bit that, unless we can also actually fix a bug or support a CSS feature on top of this, then this upgrade doesn't feel very valuable by itself.

If other folks think it's silly to try to keep the size of the compiler small, I could definitely be convinced otherwise.

@benmccann
Copy link
Member

I think even if this version doesn't fix a bug that some future version probably will at some point. There's a lot of value in this PR in making future upgrades much easier by addressing all the incompatibilities. It also makes it so that if we do encounter an issue we can report it. Being on an alpha version right now we're unsupported. It seems unlikely to me that we can permanently stay on an old version.

@Conduitry
Copy link
Member

Yeah, that's fair, I'm probably just being silly. Merging.

@Conduitry Conduitry merged commit 8867bc3 into sveltejs:master Feb 8, 2021
hontas added a commit to hontas/svelte that referenced this pull request Feb 11, 2021
@hontas
Merge branch 'master' of https://github.com/sveltejs/svelte
421f2cf 
* 'master' of https://github.com/sveltejs/svelte: (129 commits)
  -> v3.32.3
  fix remove of lone :host selectors (sveltejs#5984)
  -> v3.32.2
  update changelog
  fix extra invalidation with component prop binding to object property (sveltejs#5890)
  update css-tree@^1.1.2 (sveltejs#5958)
  fix :host and :global css scoping (sveltejs#5957)
  Tutorial : a better explanation of component events (sveltejs#4639)
  "What's new in Svelte" February newsletter (sveltejs#5925)
  Change color on 404 page (sveltejs#5932)
  -> v3.32.1
  warn module variables are nonreactive and make them truly nonreactive (sveltejs#5847)
  update changelog
  fix: "foreign" namespace elements should still allow binding 'this' (sveltejs#5942)
  inline `prop_values` in `init` helper (sveltejs#5909)
  update changelog
  don't create class update functions when dependencies aren't reactive (sveltejs#5926)
  fix extraneous store subscription in SSR (sveltejs#5929)
  make `SvelteComponentDev` typings more forgiving (sveltejs#5937)
  make animation/transition params optional (sveltejs#5936)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanhauhau @Conduitry @benmccann