Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a more descriptive message for the error generated by an empty shorthand attribute #6217

Merged
merged 7 commits into from
Jun 22, 2021
Merged

Add a more descriptive message for the error generated by an empty shorthand attribute #6217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b78b682
Error message when shorthand attribute is empty
rster2002 Apr 20, 2021
4b292d1
Reverted accicental changes to the package-lock
rster2002 Apr 20, 2021
5a18946
Fixed indentation after changes
rster2002 Apr 20, 2021
19e434f
Made final adjustment to indentation
rster2002 Apr 20, 2021
58e3339
Changed the error message to be more descriptive
rster2002 Apr 20, 2021
9ca6fa7
Renamed errorcode
rster2002 Apr 20, 2021
3448f70
Fixed test after last change
rster2002 Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/compiler/parse/state/tag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,13 @@ function read_attribute(parser: Parser, unique_names: Set<string>) {
parser.allow_whitespace();
parser.eat('}', true);

if (name === null) {
parser.error({
code: 'empty-attribute-shorthand',
message: 'Attribute shorthand cannot be empty'
}, start);
}

check_unique(name);

return {
Expand Down
10 changes: 10 additions & 0 deletions test/parser/samples/error-empty-attribute-shorthand/error.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"code": "empty-attribute-shorthand",
"message": "Attribute shorthand cannot be empty",
"start": {
"line": 1,
"column": 6,
"character": 6
},
"pos": 6
}
1 change: 1 addition & 0 deletions test/parser/samples/error-empty-attribute-shorthand/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<span {}></span>