mark indirect dependencies of <select> bindings #642
Merged
+181
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the second bug in #639. I can't claim that the implementation is all that neat — it feels like maybe some things aren't exactly where they 'belong' (e.g.
indirectDependenciesprobably belongs onDomGeneratorrather thanGenerator, but then we'd have to change howcontextualiseworks, which I didn't want to get into right now), and this probably needs to apply tobind:groupas well — but I'm a firm believer in fixing first and finessing later. And this fixes a blocking issue for me, so I'm going to merge it in and cut a release 😀