Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixes regression in iFrame animations caused by #6570 #6680

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

jacwright
Copy link
Contributor

@jacwright jacwright commented Aug 24, 2021

Which is funny, because #6570 was fixing a regression as well, to do with detached dom nodes.

Styles for transitions and animations need to be added to the document in which the element/node resides, otherwise, the CSS won't apply to it and the transition/animation won't run. This was implemented a while ago but broken recently.

Fixes #6637.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Which is funny, because #6570 was fixing a regression as well, to do with detached dom nodes.
@Conduitry Conduitry merged commit 6de3eb7 into master Aug 27, 2021
@Conduitry Conduitry deleted the gh-6637 branch August 27, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transitions and animations in iframes are broken
2 participants