[fix] handle AssignmentPattern with ObjectPattern in rewrite_identifier #6715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint
Motivation
fix #6699
Hi team!
There is a lack of consideration in handling
export
props with destructure assignment.In transforming the left of destructure assignment with AssignmentPattern (such as
let { bar = "hoge" }
inlet { bar = "hoge" } = {}
) , compiler handle only the case declaration's type is Identifier, but declaration's type in destructuring assignment with AssignmentPattern could be ObjectPattern, RestElement, ArrayPattern, AssignmentPattern. This lack of consideration caused #6699 error because such a pattern was handled as Identifier.I fixed it (and add the test about it).