Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] handle AssignmentPattern with ObjectPattern in rewrite_identifier #6715

Conversation

Shinyaigeek
Copy link
Contributor

@Shinyaigeek Shinyaigeek commented Sep 6, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Motivation

fix #6699

Hi team!
There is a lack of consideration in handling export props with destructure assignment.
In transforming the left of destructure assignment with AssignmentPattern (such as let { bar = "hoge" } in let { bar = "hoge" } = {}) , compiler handle only the case declaration's type is Identifier, but declaration's type in destructuring assignment with AssignmentPattern could be ObjectPattern, RestElement, ArrayPattern, AssignmentPattern. This lack of consideration caused #6699 error because such a pattern was handled as Identifier.

I fixed it (and add the test about it).

@Conduitry Conduitry merged commit f1f7d90 into sveltejs:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'subscribable' of undefined
2 participants