Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] adjust style directive AST output #7127

Merged
merged 1 commit into from
Jan 12, 2022
Merged

[fix] adjust style directive AST output #7127

merged 1 commit into from
Jan 12, 2022

Conversation

dummdidumm
Copy link
Member

  • deduplicate type name: Is now "StyleDirective"
  • Don't transform value array to template literal in the AST phase but in the compiler phase. This ensures other tools know what the raw output was and that start/end positions are available

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

[fix] adjust style directive AST output
45244d6 
- deduplicate type name: Is now "StyleDirective"
- Don't transform value array to template literal in the AST phase but in the compiler phase. This ensures other tools know what the raw output was and that start/end positions are available
This was referenced Jan 12, 2022
Merged
Merged
@Conduitry Conduitry merged commit 7044a32 into sveltejs:master Jan 12, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Mar 14, 2022
@dummdidumm @nevilm-lt
[fix] adjust style directive AST (sveltejs#7127)
354ea04 
- deduplicate type name: Is now "StyleDirective"
- Don't transform value array to template literal in the AST phase but in the compiler phase. This ensures other tools know what the raw output was and that start/end positions are available
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
@dummdidumm @nevilm-lt
[fix] adjust style directive AST (sveltejs#7127)
d5aa702 
- deduplicate type name: Is now "StyleDirective"
- Don't transform value array to template literal in the AST phase but in the compiler phase. This ensures other tools know what the raw output was and that start/end positions are available
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 22, 2022
@dummdidumm @nevilm-lt
[fix] adjust style directive AST (sveltejs#7127)
38a5a70 
- deduplicate type name: Is now "StyleDirective"
- Don't transform value array to template literal in the AST phase but in the compiler phase. This ensures other tools know what the raw output was and that start/end positions are available
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 22, 2022
@dummdidumm @nevilm-lt
[fix] adjust style directive AST (sveltejs#7127)
a796b91 
- deduplicate type name: Is now "StyleDirective"
- Don't transform value array to template literal in the AST phase but in the compiler phase. This ensures other tools know what the raw output was and that start/end positions are available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dummdidumm @Conduitry