[fix] Better handling of inert attribute #7931
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
inert
boolean attribute is not handled properly: like thedisabled
attribute it should not be set when false. But inspecting the DOM reveals it's set asinert="false"
which is wrong for a boolean attributeI'm not too familiar with the code base so I just added the keyword to the
attribute_lookup
. Like thehidden
attribute,inert
can apply to any HTMLElement. Sorry if my fix is partial, let me know how to improve it.Also mentioned here
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint