Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Better handling of inert attribute #7931

Closed
wants to merge 1 commit into from
Closed

[fix] Better handling of inert attribute #7931

wants to merge 1 commit into from

Conversation

fcrozatier
Copy link
Contributor

@fcrozatier fcrozatier commented Oct 12, 2022

Currently the inert boolean attribute is not handled properly: like the disabled attribute it should not be set when false. But inspecting the DOM reveals it's set as inert="false" which is wrong for a boolean attribute

<script>
let disabled = false;
let inert = false;
</script>

<button {disabled}>click me</button>

<div {inert}>some div <button>click</button></div>

<style>
[inert] {
    opacity: 50%
}
</style>

I'm not too familiar with the code base so I just added the keyword to the attribute_lookup. Like the hidden attribute, inert can apply to any HTMLElement. Sorry if my fix is partial, let me know how to improve it.

Also mentioned here

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@baseballyama
Copy link
Member

Thank you for handling this!
I added tests and create a new PR.
#7944

@baseballyama
Copy link
Member

Close in favor of #7944
I took your commit to #7944, so your name will list to commit log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants