fix: send in/out to transition fn #8318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3918 was fixed by #8068 it was noticed by @robertadamsonsmith that if your transition function is used as a combined in/out transition, it still receives
{ direction: 'both' }
when running the function instead ofin
orout
depending on the direction the transition is going. This severely limits the utility of passing thedirection
value in the first place.#3918 (comment)
I agree with him that this is a bug in the original version of #8068, so I'm sending this PR in the hopes that we can get that corrected before too long.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests
npm test
and lint the project withnpm run lint