-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a11y interactive-supports-focus
#8392
feat: add a11y interactive-supports-focus
#8392
Conversation
@ngtr6788 is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
!is_hidden_from_screen_reader(this.name, attribute_map) && | ||
!is_presentation_role(current_role) && | ||
is_interactive_roles(current_role) && | ||
is_static_element(this.name, attribute_map) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[memo]
This element doesn't throw the warning because the <span>
is not static element.
<script>
const role = "button";
</script>
<span on:click={() => {}} {role}>Submit</span>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This has been released in 3.58.0 - thanks! |
Reference: #820
Let me know if there are any improvements I can make! :)
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests
npm test
and lint the project withnpm run lint