Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass changed boolean array to derived callbacks #8656

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented May 29, 2023

This allows the callbacks to easily run complex update logic based on which store changed most recently.

Fixes #6777.

This replaces PR #6786, which was targeting Svelte 3.

HEADS UP: BIG RESTRUCTURING UNDERWAY

The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler aswell. For that reason, please don't open PRs that are large in scope, touch more than a couple of files etc. In other words, bug fixes are fine, but feature PRs will likely not be merged.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

This allows the callbacks to easily run complex update logic based on
which store changed most recently.
@vercel
Copy link

vercel bot commented May 29, 2023

@rmunn is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@rmunn
Copy link
Contributor Author

rmunn commented May 29, 2023

Note that @dummdidumm assigned #6786 to the "One Day" milestone on March 20. This one will probably also go in the same milestone.

@dummdidumm dummdidumm added this to the one day milestone May 30, 2023
@benmccann benmccann deleted the branch sveltejs:svelte-4 June 20, 2023 20:45
@benmccann benmccann closed this Jun 20, 2023
@dummdidumm dummdidumm reopened this Jun 20, 2023
@dummdidumm dummdidumm changed the base branch from version-4 to master June 20, 2023 20:51
@vercel
Copy link

vercel bot commented Aug 5, 2023

Deployment failed with the following error:

There is no GitHub account connected to this Vercel account.

@Rich-Harris
Copy link
Member

Closing Svelte 4 PRs as stale — thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide "what changed" array (of Booleans) to derived stores
4 participants