Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site-2): Home page styles(pt 2) #8720

Merged
merged 40 commits into from
Jun 15, 2023
Merged

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Jun 11, 2023

I accidentally based it off of feat/better-docs-nav branch, so for now the base is set to that branch only. Once that is merged, the base should point to sites and then we should merge this PR

@PuruVJ PuruVJ changed the base branch from master to sites June 11, 2023 09:04
@PuruVJ PuruVJ changed the base branch from sites to feat/better-docs-nav June 11, 2023 09:05
Base automatically changed from feat/better-docs-nav to sites June 12, 2023 16:29
@Rich-Harris
Copy link
Member

it only really works at some screen sizes, and breaks quite badly at others:

image image image

* simplify

* fix

* slightly better use of space

* tiny bit more room

* read the docs

* crop image

* very minor tweak

* another breakpoint

* tweak

* actually it works down to 1400px

---------

Co-authored-by: Rich Harris <git@rich-harris.dev>
@Rich-Harris Rich-Harris merged commit 9d33d14 into sites Jun 15, 2023
@Rich-Harris Rich-Harris deleted the feat/homepage-style-tweaks branch June 15, 2023 20:27
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants