Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple bindings in a single event handler #922

Merged
merged 15 commits into from
Nov 21, 2017
Merged

Multiple bindings in a single event handler #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7be5b70
failing test for #910
Rich-Harris Nov 12, 2017
38ad29e
add test for unbound indeterminate property
Rich-Harris Nov 12, 2017
13d2b67
validate indeterminate binding
Rich-Harris Nov 19, 2017
744a2bb
Merge branch 'master' into gh-910
Rich-Harris Nov 19, 2017
40a5f28
start refactoring bindings
Rich-Harris Nov 19, 2017
27871e3
tidy up
Rich-Harris Nov 19, 2017
fd4f5d2
tidy up
Rich-Harris Nov 19, 2017
64e6803
fix textareas
Rich-Harris Nov 19, 2017
85f9870
refactor
Rich-Harris Nov 20, 2017
1f43e54
almost all tests passing
Rich-Harris Nov 20, 2017
0ed093d
just media bindings to go
Rich-Harris Nov 20, 2017
722e386
all tests passing
Rich-Harris Nov 20, 2017
aa96812
rAF is related to timeupdate, not currentTime specifically
Rich-Harris Nov 20, 2017
75d29fa
tidy up
Rich-Harris Nov 21, 2017
c6259cf
tidy up
Rich-Harris Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/generators/dom/visitors/Component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,10 @@ import getTailSnippet from '../../../utils/getTailSnippet';
import getObject from '../../../utils/getObject';
import getExpressionPrecedence from '../../../utils/getExpressionPrecedence';
import { stringify } from '../../../utils/stringify';
import stringifyProps from '../../../utils/stringifyProps';
import { Node } from '../../../interfaces';
import { State } from '../interfaces';

function stringifyProps(props: string[]) {
if (!props.length) return '{}';

const joined = props.join(', ');
if (joined.length > 40) {
// make larger data objects readable
return `{\n\t${props.join(',\n\t')}\n}`;
}

return `{ ${joined} }`;
}

interface Attribute {
name: string;
value: any;
Expand Down
349 changes: 0 additions & 349 deletions src/generators/dom/visitors/Element/Binding.ts
View file
Open in desktop

This file was deleted.

Loading