-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attach globals to state object on initialisation #924
Conversation
Idea: any globals that are used in the template, we add them to the var each_value = ('Object' in state ? state.Object : Object).keys(state.todos); It means adding additional those properties to |
Turns out that approach makes a lot of sense. Unfortunately, it doesn't currently work for SSR, because Rather than hacking in a fix, I reckon it's probably time to deal with that design flaw — resolving all those dependencies is probably something that needs to happen in |
Feeling pretty good about this. Phase 2 of this refactor will probably be to move all the stuff that's currently happening in |
Ref #908. Just leaving this failing test here for now. Not totally sure what the best approach to fixing it is.