add component.destroyed property #948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 109 109
Lines 4010 4010
Branches 1287 1287
=======================================
Hits 3679 3679
Misses 148 148
Partials 183 183Continue to review full report at Codecov.
|
|
Going to close this. Can revisit in future but I don't think anybody really needs it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #935. This does of course cost a few bytes (albeit per-app, rather than per-component, apart from standalone components) so maybe it's not something we want to do. Open to feedback.