-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump alpine from 3.19.1 to 3.20.0 and other updates #62
Conversation
Update to alpine 3.20.0 https://www.alpinelinux.org/posts/Alpine-3.20.0-released.html
Warning Rate Limit Exceeded@svengo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 47 minutes and 41 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update involves changing the base image in the Dockerfile from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (3)
README.md (3)
28-28
: Consider rephrasing for conciseness.Instead of "I will be rebuilding the image on a regular basis to include updated alpine packages with important security fixes," consider "I will regularly rebuild the image to include updated Alpine packages with important security fixes."
Line range hint
142-142
: Add a comma for clarity.- Please report any problems as issue on github: + Please report any problems as an issue on GitHub,
Line range hint
145-145
: Add a comma between interjections.- Thanks Thanks to [Natanael Copa](https://github.com/ncopa) for [su-exec](https://github.com/ncopa/su-exec) and the [Tor Project](https://www.torproject.org/). + Thanks, thanks to [Natanael Copa](https://github.com/ncopa) for [su-exec](https://github.com/ncopa/su-exec) and the [Tor Project](https://www.torproject.org/).
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- Dockerfile (1 hunks)
- README.md (1 hunks)
Files skipped from review due to trivial changes (1)
- Dockerfile
Additional Context Used
LanguageTool (3)
README.md (3)
Near line 28: ‘on a regular basis’ might be wordy. Consider a shorter alternative.
Context: ...erfile) I will be rebuilding the image on a regular basis to include updated alpine packages with...
Near line 142: Consider adding a comma here.
Context: ...o work with an IPv6 address. # Feedback Please report any problems as issue on github:...
Near line 145: Consider adding a comma between these interjections.
Context: .../github.com/svengo/docker-tor/issues # Thanks Thanks to [Natanael Copa](https://github.com/n...
Markdownlint (15)
README.md (15)
26: Expected: dash; Actual: asterisk
Unordered list style
70: Expected: 0 or 2; Actual: 1
Trailing spaces
78: Expected: 0 or 2; Actual: 1
Trailing spaces
24: Expected: 1; Actual: 2
Multiple consecutive blank lines
25: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
142: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
145: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
13: null
Multiple top-level headings in the same document
25: null
Multiple top-level headings in the same document
30: null
Multiple top-level headings in the same document
142: null
Multiple top-level headings in the same document
145: null
Multiple top-level headings in the same document
26: null
Lists should be surrounded by blank lines
143: null
Bare URL used
86: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Outside diff range and nitpick comments (1)
README.md (1)
Line range hint
89-89
: Consider adding a comma after "omitted" for better readability.- If /MASK is omitted then this policy just applies to the host given. + If /MASK is omitted, then this policy just applies to the host given.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (3 hunks)
Additional Context Used
LanguageTool (4)
README.md (4)
Near line 31: ‘on a regular basis’ might be wordy. Consider a shorter alternative.
Context: ...rfile) I will be rebuilding this image on a regular basis to include updated alpine packages with...
Near line 55: Unpaired symbol: ‘'’ seems to be missing
Context: ...environment variables are used to build `/etc/tor/torrc-defaults'. For more advanced configuration you ca...
Near line 89: Possible missing comma found.
Context: ...ect[6] ADDR[/MASK][:PORT]". If /MASK is omitted then this policy just applies to the ho...
Near line 145: Consider adding a comma here.
Context: ...o work with an IPv6 address. # Feedback Please report any problems as issues on github...
Markdownlint (14)
README.md (14)
29: Expected: dash; Actual: asterisk
Unordered list style
73: Expected: 0 or 2; Actual: 1
Trailing spaces
81: Expected: 0 or 2; Actual: 1
Trailing spaces
27: Expected: 1; Actual: 2
Multiple consecutive blank lines
28: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
145: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
13: null
Multiple top-level headings in the same document
28: null
Multiple top-level headings in the same document
33: null
Multiple top-level headings in the same document
145: null
Multiple top-level headings in the same document
29: null
Lists should be surrounded by blank lines
146: null
Bare URL used
55: null
Spaces inside code span elements
89: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined
@coderabbitai review |
Actions PerformedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
README.md (1)
Line range hint
91-91
: Consider adding a comma after "ADDR[/MASK]" for clarity.- "accept[6]|reject[6] ADDR[/MASK][:PORT]" + "accept[6]|reject[6] ADDR[/MASK], [:PORT]"
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (3 hunks)
Additional Context Used
LanguageTool (2)
README.md (2)
Near line 91: Possible missing comma found.
Context: ...ect[6] ADDR[/MASK][:PORT]". If /MASK is omitted then this policy just applies to the ho...
Near line 148: Consider adding a comma here.
Context: ... work with an IPv6 address. # Feedback Please report any problems as issues on github...
Markdownlint (15)
README.md (15)
75: Expected: 0 or 2; Actual: 1
Trailing spaces
83: Expected: 0 or 2; Actual: 1
Trailing spaces
13: Expected: 1; Actual: 2
Multiple consecutive blank lines
28: Expected: 1; Actual: 2
Multiple consecutive blank lines
34: Expected: 1; Actual: 2
Multiple consecutive blank lines
147: Expected: 1; Actual: 2
Multiple consecutive blank lines
29: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
148: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
14: null
Multiple top-level headings in the same document
29: null
Multiple top-level headings in the same document
35: null
Multiple top-level headings in the same document
148: null
Multiple top-level headings in the same document
30: null
Lists should be surrounded by blank lines
149: null
Bare URL used
91: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined
Additional comments not posted (1)
README.md (1)
30-30
: Update the Dockerfile link to match the new Alpine version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (4 hunks)
Additional Context Used
LanguageTool (3)
README.md (3)
Near line 30: Loose punctuation mark.
Context: ...spondingDockerfile
links - [latest
,0.4.8.11
](https://github.com/svengo/d...
Near line 56: Possible missing comma found.
Context: .../tor/torrc-defaults. For more advanced configuration you can edit the
/data/torrc` configur...
Near line 90: Possible missing comma found.
Context: ...ect[6] ADDR[/MASK][:PORT]". If /MASK is omitted then this policy just applies to the ho...
Markdownlint (3)
README.md (3)
13: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time
27: Expected: 1; Actual: 2
Multiple consecutive blank lines
90: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
1 similar comment
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/codacy.yml (1 hunks)
- README.md (4 hunks)
- docker-compose.yml (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/codacy.yml
- docker-compose.yml
Additional Context Used
LanguageTool (2)
README.md (2)
Near line 29: Loose punctuation mark.
Context: ...spondingDockerfile
links - [latest
,0.4.8.11
](https://github.com/svengo/d...
Near line 89: A comma might be missing here.
Context: ...host given. Instead of giving a host or network you can also use "*" to denote the univ...
Markdownlint (1)
README.md (1)
89: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined
GitHub Check Runs (1)
Codacy Static Code Analysis action_required (1)
README.md: [notice] 89-89: README.md#L89
Missing link or image reference definition: ":port"
Additional comments not posted (1)
README.md (1)
Line range hint
69-147
: The environment variable descriptions are clear and detailed.
Update to alpine 3.20.0
https://www.alpinelinux.org/posts/Alpine-3.20.0-released.html
Summary by CodeRabbit
alpine:3.30.0
for improved security and performance.latest
and0.4.8.11
tags in the README.md for better reference.codacy.yml
for Codacy Security Scan in .github/workflows directory.daemon
in docker-compose.yml.