-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to tor 0.4.8.12 #68
Conversation
WalkthroughThe recent update involves a minor version bump for the Tor software used in the Docker container. Specifically, the Tor version has been updated from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
Dockerfile (1)
Line range hint
9-9
: Consider using WORKDIR for clarity, pinning versions in apk add, and using--no-cache
for apk to optimize the build process and ensure reproducibility.- apk update && \ - apk add \ + apk add --no-cache \ curl=7.79.1 \ gettext=0.21 \ libcap=2.44 \ libevent=2.1.12 \ su-exec=0.2 \ xz-libs=5.2.5 \ zlib=1.2.11 \ zstd-libs=1.4.9 \
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- Dockerfile (1 hunks)
- README.md (1 hunks)
Additional context used
Hadolint
Dockerfile
[warning] 9-9: Use WORKDIR to switch to a directory (DL3003)
[warning] 9-9: Pin versions in apk add. Instead of
apk add <package>
useapk add <package>=<version>
(DL3018)
[info] 9-9: Double quote to prevent globbing and word splitting. (SC2086)
[info] 9-9: Use the
--no-cache
switch to avoid the need to use--update
and remove/var/cache/apk/*
when done installing packages (DL3019)
LanguageTool
README.md
[uncategorized] ~29-~29: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...spondingDockerfile
links - [latest
,0.4.8.12
](https://github.com/svengo/d...
Additional comments not posted (2)
Dockerfile (1)
4-4
: Updated TOR_VERSION to 0.4.8.12 aligns with the PR's objective.README.md (1)
29-29
: Updated Docker tag to0.4.8.12
correctly reflects the new Tor version as per the Dockerfile update.Tools
LanguageTool
[uncategorized] ~29-~29: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...spondingDockerfile
links - [latest
,0.4.8.12
](https://github.com/svengo/d...
https://forum.torproject.org/t/stable-release-0-4-8-12/13060
Here is the ChangeLog.
Changes in version 0.4.8.12 - 2024-06-06
This is a minor release with couple bugfixes affecting conflux and logging.
We also have the return of faravahar directory authority with new keys and
address.
retrieved on 2024/06/06.
already emits a protocol warning log. Fixes bug 40932; bugfix
on 0.4.8.1-alpha.
Conflux set. Fixes bug 40921; bugfix on 0.4.8.1-alpha.
This lead to a non fatal BUG() spamming logs. Fixes bug 40908;
bugfix on 0.4.8.1-alpha.
Summary by CodeRabbit
0.4.8.12
.0.4.8.12
.