Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add throtteling to request #190

Closed
svenkubiak opened this issue Jun 18, 2016 · 6 comments
Closed

Add throtteling to request #190

svenkubiak opened this issue Jun 18, 2016 · 6 comments
Milestone

Comments

@svenkubiak
Copy link
Owner

Add an additonal parameter which enables throtteling of request, e.g. max 5 req/sec.

@svenkubiak svenkubiak added this to the 3.4.0 milestone Jun 18, 2016
@MarkVink
Copy link
Contributor

Will the max of 5req/sec be applied to each user individually trying to access a certain route, or the route itself?

@svenkubiak
Copy link
Owner Author

Per user (IP) accessing a specific route.

@MarkVink
Copy link
Contributor

MarkVink commented Jun 18, 2016

Thats cool!

In that case also reminds that in most cases the app runs behind a reverse proxy which has to pass IP headers.

@svenkubiak
Copy link
Owner Author

Yes, you're right. We should keep that in mind. Are there alternatives?

@MarkVink
Copy link
Contributor

The application has access to (session) cookies for sure, although its not a reliable basis for throttling. So, the application must be sure its provided with an IP address, or its not able to distinguish between users.

@svenkubiak svenkubiak modified the milestones: 4.0.0, 3.4.0 Jul 4, 2016
@svenkubiak
Copy link
Owner Author

Moved to 4.0.0 as this requires some new feature from 4.0.0

svenkubiak added a commit that referenced this issue Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants