Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"--random-route" leaks the 6-hexdigit token in 404 pages #173

Closed
dsferruzza opened this issue Aug 4, 2019 · 1 comment · Fixed by #177
Closed

"--random-route" leaks the 6-hexdigit token in 404 pages #173

dsferruzza opened this issue Aug 4, 2019 · 1 comment · Fixed by #177

Comments

@dsferruzza
Copy link

Hi!

I believe that the --random-route option is meant to be used as a "soft authentication method", as shown in the README example.
Unfortunately, the generated token seems to appear in 404 pages, which makes the whole feature awkwardly useless...
I am using miniserve 0.5.0 (downloaded from the releases page) on Windows 10.

Here is what I get when doing miniserve --random-route and then curl http://127.0.0.1:8080/:

<body>
    <!DOCTYPE html>
    <html>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title>404 Not Found</title>
    <else>
        <title>Index of 404 Not Found</title>
    </else>
    <style>
        /* CSS code */
    </style>

    </html>
    <div class="error">
        <p>404 Not Found</p>
        <p>Route / could not be found</p>
        <div class="error-nav"><a class="error-back" href="/b0e615">Go back to file listing</a></div>
    </div>
</body>

(HTML code was reformatted to improve readability.)

  1. You can see the link to /[token] at the end
  2. What's up the HTML markup BTW? It makes little sense...
@ghost ghost mentioned this issue Aug 16, 2019
Merged
@ghost
Copy link

ghost commented Aug 16, 2019

Good catch by the way

svenstaro added a commit that referenced this issue Feb 27, 2020
@svenstaro
Merge pull request #177 from ghost/fix-#173
09f2d24 
Fix #173
@steffhip steffhip mentioned this issue Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #173
1 participant
@dsferruzza