Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set the accept input attribute to arbitrary values #755

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

mayjs
Copy link
Contributor

@mayjs mayjs commented Mar 12, 2022

This supersedes #750.
It still solves #546 but may also prove to be useful in other scenarios by allowing to set more mediatypes.

@svenstaro
Copy link
Owner

Pretty neat and clean! I'd almost be happy to accept it as is but I think this feature is complex enough to require another example line of documentation in the README and also I'd like to see a test for this. The test should be rather simple and you can copy from the existing body of tests.

@mayjs
Copy link
Contributor Author

mayjs commented Mar 13, 2022

Thanks for the feedback!

I added some tests and a line for the README.
How / when do you update the USAGE section in the README?
Is that something you do when a new release is created or should I adjust that part as well?
I was worried about the version number.

Are the tests fine for you or did you have something else in mind?
Thanks for making me write them, that way I learned about rstest and how easily you can do fixture-based testing and parametrized tests using it 🙂.

@mayjs mayjs force-pushed the upload-mediatypes branch from 971c8d2 to 8e37888 Compare March 13, 2022 18:17
@svenstaro
Copy link
Owner

Don't worry about updating the usage, I will do it with the next release. :)

Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! :)

src/args.rs Show resolved Hide resolved
tests/upload_files.rs Show resolved Hide resolved
@svenstaro svenstaro merged commit e23bcd4 into svenstaro:master Mar 15, 2022
svenstaro added a commit that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants