Some refactoring #846
Closed
Some refactoring #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyqsimon
commented
Jul 20, 2022
| @@ -219,10 +219,10 @@ pub fn directory_listing( | |||
|
|
|||
| // If the `qrcode` parameter is included in the url, then should respond to the QR code | |||
| if let Some(url) = query_params.qrcode { | |||
| let res = match QrCode::encode_text(&url, QrCodeEcc::Medium) { | |||
There was a problem hiding this comment.
Looks like someone was in a hurry and overlooked this. url is not actually the URL, so we're basically encoding an arbitrary query value.
There was a problem hiding this comment.
But I'm not sure how to fix this. What should this QR code point to, exactly? (Or more broadly, what's the purpose of this QR code?) And if it points to the current URL, should the qrcode query be removed?
|
Hey, thanks! Is there any chance to split this up into individual PRs? I especially like the QR Code work. |
Yeah sure thing. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some rather ugly code so I did some refactoring.
Things of note:
rustfmt.tomlqrcodegentoqrcodecrate for QR code support