use createReadStream

svenstaro · Jan 31, 2023 · f2899b4 · f2899b4
1 parent af306bd
commit f2899b4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -75,7 +75,7 @@ function upload_to_release(release, file, asset_name, tag, overwrite, octokit) {
             return;
         }
         const file_size = stat.size;
-        const file_bytes = fs.readFileSync(file).toString('binary');
+        const file_bytes = fs.createReadStream(file);
         // Check for duplicates.
         const assets = yield octokit.paginate(repoAssets, Object.assign(Object.assign({}, repo()), { release_id: release.data.id }));
         const duplicate_asset = assets.find(a => a.name === asset_name);
@@ -9572,7 +9572,9 @@ function fetch(url, opts) {
 				return;
 			}
 
-			destroyStream(response.body, err);
+			if (response && response.body) {
+				destroyStream(response.body, err);
+			}
 		});
 
 		/* c8 ignore next 18 */

diff --git a/src/main.ts b/src/main.ts
@@ -66,7 +66,7 @@ async function upload_to_release(
     return
   }
   const file_size = stat.size
-  const file_bytes = fs.readFileSync(file).toString('binary')
+  const file_bytes: any = fs.createReadStream(file)
 
   // Check for duplicates.
   const assets: RepoAssetsResp = await octokit.paginate(repoAssets, {