fix: Clean up zookeeper #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverrehu
added a commit
that referenced
this pull request
Sep 12, 2023
The Zookeeper dependency is required for a single test method only. This PR moves all ZK* classes to src/test, and marks the zookeeper dependency as test-coped. Unfortunately, recent versions of zookeeper drag in a logback dependency, that appears to turn on global DEBUG logging. So this PR also exludes those logback dependencies. Fixes kafka-ops#548
sverrehu
added a commit
that referenced
this pull request
Sep 12, 2023
* fix: Apply formatting, using a formatter that supports Java 17 * fix: Don't throw exception if JulieOps is not allowed to delete topics (#3) * Don't throw exception if JuleOps is not allowed to delete topics. * Update dependencies (#2) * Update README.md * fix: Apply formatting, using a formatter that supports Java 17 * chore: Update dependencies * chore: Update dependencies * Update container versions * fix: Replace deprecated AssertJ method * chore: Upgrade Confluent version in workflow * fix: Replace deprecated methods * fix: Replace deprecated methods * chore: Update dependencies * fix: Extend connector path for new version of connect * fix: Revert ksqldb-server to a version that makes the test pass * fix: Correct return value from exception handler * fix: Hack around bug KAFKA-14325 * feat: Support finding topology files recursively (#4) * fix: Clean up zookeeper (#5) The Zookeeper dependency is required for a single test method only. This PR moves all ZK* classes to src/test, and marks the zookeeper dependency as test-coped. Unfortunately, recent versions of zookeeper drag in a logback dependency, that appears to turn on global DEBUG logging. So this PR also exludes those logback dependencies. Fixes kafka-ops#548 * fix: Allow logging of INFO+ from AdminClient (#6) * Excludes all Log4j2Plugins.dat from the shaded jar, to avoid Log4j2 startup problems (ERROR StatusLogger Unrecognized conversion specifier...) * Adds a log4j.properties that will be picked up by the Kafka dependencies * Create dependabot.yml * chore: Update plug-in versions * chore: Update jackson and redis to remove vulnerable json and snakeyaml packages * chore: Update plugins * chore: Update some deps * chore: Upgrade testcontainers * Updates (#8) * chore: Update some deps * chore: Update some deps * chore: Upgrade Confluent Platform * docs: Fetch changelog from v4.4.1 tag to get all history * chore: Remove unused imports and trailing whitespace (#9) * chore: Remove unused imports * docs: Remove trailing spaces * Update src/test/java/com/purbon/kafka/topology/integration/MDSBaseTest.java Co-authored-by: piotrsmolinski <piotr.smolinski.77@gmail.com> --------- Co-authored-by: piotrsmolinski <piotr.smolinski.77@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Zookeeper dependency is required for a single test method only. This PR moves all
ZK*classes tosrc/test, and marks the zookeeper dependency as test-coped.Unfortunately, recent versions of zookeeper drag in a logback dependency, that appears to turn on global DEBUG logging. So this PR also exludes those logback dependencies.
Fixes kafka-ops#548