fix(removeUselessDefs): dont remove node if children has id (#1923)

svg · Jan 3, 2024 · 51c59f5 · 51c59f5
1 parent 2442f74
commit 51c59f5
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 6 deletions.
diff --git a/plugins/removeUselessDefs.js b/plugins/removeUselessDefs.js
@@ -19,7 +19,11 @@ export const fn = () => {
   return {
     element: {
       enter: (node, parentNode) => {
-        if (node.name === 'defs') {
+        if (
+          node.name === 'defs' ||
+          (elemsGroups.nonRendering.has(node.name) &&
+            node.attributes.id == null)
+        ) {
           /**
            * @type {XastElement[]}
            */
@@ -36,11 +40,6 @@ export const fn = () => {
             });
           }
           node.children = usefulNodes;
-        } else if (
-          elemsGroups.nonRendering.has(node.name) &&
-          node.attributes.id == null
-        ) {
-          detachNodeFromParent(node, parentNode);
         }
       },
     },

diff --git a/test/plugins/removeUselessDefs.04.svg b/test/plugins/removeUselessDefs.04.svg
diff --git a/test/plugins/removeUselessDefs.05.svg b/test/plugins/removeUselessDefs.05.svg