fix(plugin): removeAttrs: warn without attrs (#1582)

svg · Sep 23, 2021 · 8af10de · 8af10de
1 parent 6e23b9c
commit 8af10de
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/plugins/removeAttrs.js b/plugins/removeAttrs.js
@@ -6,6 +6,19 @@ exports.active = false;
 exports.description = 'removes specified attributes';
 
 const DEFAULT_SEPARATOR = ':';
+const ENOATTRS = `Warning: The plugin "removeAttrs" requires the "attrs" parameter.
+It should have a pattern to remove, otherwise the plugin is a noop.
+Config example:
+
+plugins: [
+  {
+    name: "removeAttrs",
+    params: {
+      attrs: "(fill|stroke)"
+    }
+  }
+]
+`;
 
 /**
  * Remove attributes
@@ -77,7 +90,11 @@ const DEFAULT_SEPARATOR = ':';
  * }>}
  */
 exports.fn = (root, params) => {
-  // wrap into an array if params is not
+  if (typeof params.attrs == 'undefined') {
+    console.warn(ENOATTRS);
+    return null;
+  }
+
   const elemSeparator =
     typeof params.elemSeparator == 'string'
       ? params.elemSeparator

diff --git a/test/plugins/removeAttrs.06.svg b/test/plugins/removeAttrs.06.svg