Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global floatPrecision cannot be inherited in plugins with default floatPrecision #1426

Closed
jlherren opened this issue Mar 15, 2021 · 3 comments
Closed

Global floatPrecision cannot be inherited in plugins with default floatPrecision #1426

jlherren opened this issue Mar 15, 2021 · 3 comments
Labels
bug solved in main

Comments

@jlherren
Copy link
Contributor

I can't seem to reopen #1407, but the bug is still not fixed in 2.2.2 unfortunately. Steps to reproduced are as given in that bug report, with that exact svgo.config.js file.
@jlherren jlherren added the bug label Mar 15, 2021
@TrySound TrySound changed the title Disabling a plugin causes floatPrecision to be ignored Global floatPrecision cannot be inherited in plugins with default floatPrecision Mar 15, 2021
TrySound added a commit that referenced this issue Mar 22, 2021
@TrySound
Override default floatPrecision with global
7389bcd 
Ref #1426

Previously extendDefaultPlugins incorrectly overrided global
floatPrecision.
@TrySound
Copy link
Member

Gotcha. Sorry for wait. Fixed in 7389bcd

Will release soon.

@TrySound
Copy link
Member

Fixed in https://github.com/svg/svgo/releases/tag/v2.3.0

@jlherren
Copy link
Contributor Author

Awesome, works now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug solved in main
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlherren @TrySound