feat: remove useless closing path segments #1751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguddas
force-pushed
the
feat/remove-useless-closing-path-segments
branch
from
96df62a
to
f74146a
Compare
jguddas
force-pushed
the
feat/remove-useless-closing-path-segments
branch
from
f74146a
to
23cc2e6
Compare
This was referenced Mar 3, 2023
|
Sorry that this wasn't reviewed in a reasonable time. The maintainers were busy and I just joined recently! This has been tackled in a recent PR and should be resolved in If you have any qualms with the implementation, or can identify an edge case (with a minimal reproducible example) that isn't handled how you'd expect, then feel free to open another issue/PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between those 2, is that the left side has has no close path command but is still closed due to ending at the start point.