Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed Config definition for node #1997

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Conversation

nuintun
Copy link
Contributor

@nuintun nuintun commented May 9, 2024

Re export Config definition for node module.

image

@XhmikosR
Copy link
Contributor

XhmikosR commented May 9, 2024

Just thinking out loud here, can't you just export from directly instead of importing and then exporting?

EDIT: NVM, the import is used elsewhere, sorry for the noise :)

@nuintun
Copy link
Contributor Author

nuintun commented May 9, 2024

@XhmikosR

import { Config, optimize } from './svgo';

export { Config, optimize };

are equal to

export { Config, optimize } from './svgo';

Directly export is just a syntax sugar for reexport variables that are not used in the current code.

@SethFalco
Copy link
Member

SethFalco commented Jun 9, 2024

Hey, thanks for submitting the PR! I've rebased for you and amended the commit to export everything instead, which matches the exports in previous versions.

@SethFalco SethFalco merged commit 1a025da into svg:main Jun 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants