fix: cleanupIds changes style IDs incorrectly #2057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a style references 2 ids (e.g.,
fill:url(#c);stroke:url(#b);
), and the IDs were changed so that c=>b and b=>a, cleanupIds was only changing the first element in the style twice.This was very unlikely to happen on the first pass (regression results were unchanged), but common on subsequent passes (with multipass, regression results went from 467 failures and 199,877 pixel mismatches before the fix to 128 failures and 6,337 pixel mismatches after.
This PR fixes the issue by changing all references in the style at once. This required some rearranging and additional bookkeeping, in particular:
Note: this was originally PR #1956, but that PR got closed when I rebased.