Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ResultAssert methods. #12

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Change ResultAssert methods. #12

merged 1 commit into from
Dec 4, 2024

Conversation

marcindabrowski
Copy link
Contributor

@marcindabrowski marcindabrowski commented Dec 4, 2024 •
edited
Loading

  • change hasErrorThat to be as one that we have discussed
  • remove unnecessary specializations (hasErrorEqualTo, hasSuccessEqualTo)
  • convert all the tests in ResultCollectorsTest.java in result4j-assertj to use ResultAssert or remove those that do not need ResultAssert

@marcindabrowski
Change ResultAssert methods.
2433ce8 
[x] change hasErrorThat to be as one that we have discussed
[x] remove unnecessary specializations (hasErrorEqualTo, hasSuccessEqualTo)
[x] convert all the tests in ResultCollectorsTest.java in result4j-assertj to use ResultAssert or remove those that do not need ResultAssert
@marcindabrowski marcindabrowski mentioned this pull request Dec 4, 2024
Merged
@sviperll sviperll merged commit 0fedabe into sviperll:feature/assertj Dec 4, 2024
1 check passed
@marcindabrowski marcindabrowski deleted the feat/rework-result-assert branch December 6, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcindabrowski @sviperll