Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node:fs version of realpath #7

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Use node:fs version of realpath #7

merged 2 commits into from
Dec 17, 2022

Conversation

stephenlrandall
Copy link
Contributor

As mentioned in this issue, the node:fs/promises version of realpath has different behavior from the node:fs version used by vite:resolve.

bluwy
bluwy approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging this! This is quite a surprising behaviour from nodejs, but it makes sense to align this change.

@bluwy bluwy merged commit 19a9418 into svitejs:main Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenlrandall @bluwy