Support DLQ redrive in redis #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymell
force-pushed
the
james/redrive-dlq
branch
2 times, most recently
from
1336068
to
eb904d1
Compare
jaymell
force-pushed
the
james/redrive-dlq
branch
2 times, most recently
from
b631524
to
8d6e8bb
Compare
Support redriving the DLQ directly from the QueueProducer. Is this a good idea? Sure! Only supported in Redis for now.
1. Add missing tests to redis_cluster module 2. redis::test_backward_compatible had logic that should have been in redis::test_deadletter_config, so relocated that as appropriate.
jaymell
force-pushed
the
james/redrive-dlq
branch
from
8d6e8bb
to
d0b518b
Compare
jaymell
commented
Sep 6, 2024
I'm not sure if we need to generically guarantee this in our docs, but it seems reasonable to validate it in our tests for now.
jaymell
force-pushed
the
james/redrive-dlq
branch
from
ef7d82e
to
71ad767
Compare
|
@svix-onelson Mind taking a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support redriving the DLQ directly from the QueueProducer. Is
this a good idea? Sure! Only supported in Redis for now.