CI improvements #23
Merged
CI improvements #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo.lock is removed from paths because it is not part of the repository anyways.
Given that there is only one package in it so that this is effectively a no-op, but it simplifies the CI setup with no practical downsides.
For clippy and test, --all is deprecated in favor of --workspace, but is also a no-op for workspaces unless some workspace members are not default members. For fmt, it already operates on the whole workspace by default; --all just additionally includes non-workspace path dependencies (super rare and should likely never be committed anyways).
svix-gabriel
approved these changes
Feb 6, 2024
svix-gabriel
added a commit
to svix/svix-webhooks
that referenced
this pull request
Feb 7, 2024
Subset of the changes I did for omniqueue's CI yesterday: svix/omniqueue-rs#23 CI failures are unrelated and will be fixed through #1194.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of small improvements. Maybe most importantly, this gets rid of deprecation warnings about Node 16 actions, which the deprecated / archived
actions-rsactions were triggering: