Add redis eviction-policy check/warning #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymell
commented
Apr 25, 2024
jaymell
force-pushed
the
check-eviction-policy
branch
2 times, most recently
from
c171eed
to
32322e4
Compare
We want to warn users if queues are at potential risk of deletion in low-memory situations. Add a startup check that will log a warning if the eviction policy can't be determined or if an unsafe eviction policy is found. Note: The `warn` is likely to fire all the time on cloud providers, which tend to disable the `CONFIG` command entirely.
jaymell
force-pushed
the
check-eviction-policy
branch
from
32322e4
to
0633a1a
Compare
svix-gabriel
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to warn users if queues are at potential risk of deletion in low-memory situations. Add a startup check that will log a warning if the eviction policy can't be determined or if an unsafe eviction policy is found.
Note: The
warnis likely to fire all the time on cloud providers, which tend to disable theCONFIGcommand entirely.