Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: Use associated type bounds to simplify RedisConnection trait #88

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

svix-jplatte
Copy link
Member

Rust 1.79.0, which includes this feature, stabilizes today.

@svix-jplatte svix-jplatte force-pushed the jplatte/associated-type-bounds branch from bd5c76b to 97bd084 Compare June 13, 2024 15:36
@svix-jplatte svix-jplatte marked this pull request as ready for review June 13, 2024 15:51
@svix-jplatte svix-jplatte requested a review from a team as a code owner June 13, 2024 15:51
Copy link
Contributor

@svix-gabriel svix-gabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping the rust version, do we also need to bump the version of omniqueue?

@svix-jplatte
Copy link
Member Author

We have other breaking changes, I think we should bump when doing the release. (otherwise [patch] breaks, and people get confused more so than like this IME)

@svix-jplatte svix-jplatte merged commit 379b34b into main Jun 13, 2024
5 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/associated-type-bounds branch June 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants