Further CI improvements #1199
Merged
Further CI improvements #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-jplatte
changed the title
Only for Rust workflows for now, because those run the most and also take the most time to run.
svix-james
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the first commit: In #1188 there were some panics in tests, but without a backtrace they were pretty useless (they occurred inside the Rust standard library). By setting
RUST_BACKTRACE=1in the two CI jobs that run tests, we should get more useful output if this ever happens again in the future.About the second commit: Simply less scary,
masterof the checkout action could have different behavior with the next major version.