Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Remove unused optional PostOptions parameters from non-POST methods #1557

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

svix-jplatte
Copy link
Member

Motivation

These parameters are useless, and get ignored.

Solution

Remove.

@svix-jplatte svix-jplatte force-pushed the jplatte/non-post-idempotency branch from 28381b7 to 4594c7c Compare December 10, 2024 21:59
@svix-jplatte svix-jplatte force-pushed the jplatte/non-post-idempotency branch from 4594c7c to 57d12df Compare December 10, 2024 22:38
@svix-jplatte svix-jplatte marked this pull request as ready for review December 10, 2024 22:41
@svix-jplatte svix-jplatte requested a review from a team as a code owner December 10, 2024 22:41
@svix-jplatte svix-jplatte merged commit ff0ccbc into main Dec 10, 2024
4 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/non-post-idempotency branch December 10, 2024 23:18
@svix-jplatte svix-jplatte mentioned this pull request Dec 12, 2024
svix-jplatte added a commit that referenced this pull request Dec 12, 2024
## What's changed

* Libs/JavaScript: Revert packaging-related change because it broke for
some users ([#1556])
* Libs/Rust: Remove unused optional `PostOptions` parameters from
non-POST methods ([#1557])

[#1556]: #1556
[#1557]: #1557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants