Don't prepend success/error suffixes with "_" #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrefgneves Hi, i don't believe I understand reasons. Can you write little bit more? |
|
Hi, sure. Sorry for not being clear. Basically, you currently force the "" on the success/error suffix, so there's no way to have the action type be exactly what I want it to be, the "" will always be there. What I'm personally trying to achieve is what you can see on the screenshot above. I would like to replace the "_" before the X on "[Blog] Load Posts_X" with a space. |
|
Got it. Now it's clear. Thanks for your PR. |
|
Thank you |
|
@andrefgneves Published with version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be nitpicking but it would allow for "cleaner" action types.
I would like to remove that extra "_":