Update scala's model.mustache to set a default value of None for optional fields (as in 2.4) #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing default value of None for optional fields is critical for significantly less boilerplate code, and backwards compatibility with anyone using the previous version of swagger-codegen
|
What's the process to get this merged? Thanks. |
|
hey @Enrico2 , sorry for this long reply. I'll help with your PR |
|
Hey @HugoMario , thanks but given that it's been almost 2 years, as you might imagine this has become stale for me. I'm no longer working for the company that used this library, however, just looked at the current model.mustache file (in its new location) and it's still missing the default value. I'm not motivated to do anything about that anymore, but if you are maintaining this repository, I think it's a worthwhile change. |
HugoMario
added a commit
that referenced
this pull request
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing default value of None for optional fields is critical for significantly less boilerplate code, and backwards compatibility with anyone using the previous version of swagger-codegen.
The line was copied from https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/scala/model.mustache