Replace dataType with baseType+containerType to fix compilation error in AkkaHttpServerCodegen #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of
scala-akka-http-server
generator doesn't produce correct code if the response type isarray
. For example, for petstore it producesThis code is not valid because
responseList[Pet]
etc contains the type with brackets ({{dataType}}
inapi.mustache
templates).This PR fixes this by using
{{baseType}}{{containerType}}
instead, which produces:I had to change the type of
complexReturnTypes
fromSet<String>
toList<CodegenResponse>
, which is necessary as far as I understand the code.I'm not a Java developer, and it's the first time I use this project, so please let me know if something can be improved.