-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURITY] Code generator generates projects with insecure repositories #9210
Comments
Ping! |
frantuma
added a commit
that referenced
this issue
Apr 19, 2019
frantuma
added a commit
to swagger-api/swagger-codegen-generators
that referenced
this issue
Apr 19, 2019
frantuma
added a commit
that referenced
this issue
Apr 19, 2019
ref #9210 - update http urls to https
frantuma
added a commit
to swagger-api/swagger-codegen-generators
that referenced
this issue
Apr 19, 2019
ref swagger-api/swagger-codegen/issues/9210 - update http urls to https
fixed in #9389 |
Has a CVE been issued? |
Also, what version was this released as 'fixed' in? |
we are working on the CVE process, and will notify about updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CWE-829: Inclusion of Functionality from Untrusted Control Sphere
CWE-494: Download of Code Without Integrity Check
This project is generating starter projects that are resolving dependencies over HTTP instead of HTTPS.
Additionally, the sample associated with this project are vulnerable to this as well. Any of these artifacts could have been MITM to maliciously compromise them and infect the build artifacts that were produced. Additionally, if any of these JARs or other dependencies were compromised, any developers using these could continue to be infected past updating to fix this.
This vulnerability has a CVSS v3.0 Base Score of 8.1/10
https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H
This isn't just theoretical
POC code has existed since 2014 to maliciously compromise a JAR file inflight.
See:
MITM Attacks Increasingly Common
See:
Source Locations
swagger-codegen/modules/swagger-codegen/src/main/resources/Groovy/build.gradle.mustache
Lines 11 to 13 in 4607a90
swagger-codegen/modules/swagger-codegen/src/main/resources/Groovy/build.gradle.mustache
Lines 22 to 23 in 4607a90
swagger-codegen/samples/client/petstore/groovy/build.gradle
Lines 11 to 13 in 4607a90
swagger-codegen/samples/client/petstore/groovy/build.gradle
Lines 22 to 23 in 4607a90
swagger-codegen/samples/server/petstore/kotlin-server/ktor/build.gradle
Line 60 in 4607a90
swagger-codegen/modules/swagger-codegen/src/main/resources/kotlin-server/libraries/ktor/build.gradle.mustache
Line 60 in 4607a90
swagger-codegen/modules/swagger-codegen/src/main/resources/finch/build.sbt
Line 13 in 4607a90
swagger-codegen/modules/swagger-codegen/src/main/resources/finch/build.sbt
Lines 17 to 19 in 4607a90
Public Disclosure
This issue requires public disclosure as it impacts users that have used this project to generate their starter projects.
A project maintainer needs to file for a CVE number to inform the public about this vulnerability.
If a maintainer on this project works for or is associated with a CNA, please have them file it with them:
cve.mitre.org/cve/request_id.html
Otherwise, an open source CVE should be filed for here:
iwantacve.org
The text was updated successfully, but these errors were encountered: