Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect configured generator URL in swagger config #11714

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Feb 18, 2022

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

During the work for #11711 I recognized that the generated OpenAPI spec does not reflect the GENERATOR_HOST which causes wrong generated code and non-functional snippets in the UI.

This PR improves that by passing on the relevant parts to the swagger config.

🛠 with ❤ at Siemens

@fgreinacher fgreinacher marked this pull request as ready for review February 18, 2022 12:33
@fgreinacher
Copy link
Contributor Author

@frantuma As you got some context here, would you have a look?

@frantuma frantuma merged commit 278a1c1 into swagger-api:master Feb 19, 2022
@fgreinacher fgreinacher deleted the fix/generator-host-in-spec branch February 19, 2022 08:53
@fgreinacher
Copy link
Contributor Author

fgreinacher commented Feb 21, 2022

@frantuma Thanks a ton for merging that quickly! Can you already estimate when this will be released?

@frantuma
Copy link
Member

@fgreinacher no fixed ETA, probably within 2 weeks

@fgreinacher
Copy link
Contributor Author

fgreinacher commented Mar 9, 2022

@fgreinacher no fixed ETA, probably within 2 weeks

@frantuma Don't wanna push too hard here, but do you already have an idea about the next release data? Forget that, I just found out that the base path is not applied proplerly. Working on a fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants