Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force explicit configuration of CA cert location #2003

Merged
merged 1 commit into from
Jan 29, 2016
Merged

Don't force explicit configuration of CA cert location #2003

merged 1 commit into from
Jan 29, 2016

Conversation

tsujigiri
Copy link
Contributor

In order to allow openssl to figure out the location of CA certificates
on its own, don't apply the ssl_ca_cert configuration parameter if it
is not explicitly set.

@wing328
Copy link
Contributor

wing328 commented Jan 29, 2016

@tsujigiri the change looks good to me. Do you mind updating the Ruby Petstore API as mentioned in the contributing guideline? https://github.com/swagger-api/swagger-codegen/wiki/Guidelines-for-Contribution

@wing328 wing328 added this to the v2.1.6 milestone Jan 29, 2016
@tsujigiri
Copy link
Contributor Author

Sure.

@tsujigiri
Copy link
Contributor Author

I updated the pull-request, but I wasn't able to run the tests:

# mvn -e integration-test -rf :RubyPetstoreClientTests
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.swagger:swagger-codegen:jar:2.1.6-SNAPSHOT
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-jar-plugin @ io.swagger:swagger-codegen:[unknown-version], /home/helge/code/swagger-codegen/modules/swagger-codegen/pom.xml, line 106, column 21
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-source-plugin @ io.swagger:swagger-codegen-project:2.1.6-SNAPSHOT, /home/helge/code/swagger-codegen/pom.xml, line 176, column 21
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.swagger:swagger-codegen-cli:jar:2.1.6-SNAPSHOT
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-source-plugin @ io.swagger:swagger-codegen-project:2.1.6-SNAPSHOT, /home/helge/code/swagger-codegen/pom.xml, line 176, column 21
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.swagger:swagger-codegen-maven-plugin:maven-plugin:2.1.6-SNAPSHOT
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-source-plugin @ io.swagger:swagger-codegen-project:2.1.6-SNAPSHOT, /home/helge/code/swagger-codegen/pom.xml, line 176, column 21
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.swagger:swagger-generator:war:2.1.6-SNAPSHOT
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-source-plugin @ io.swagger:swagger-codegen-project:2.1.6-SNAPSHOT, /home/helge/code/swagger-codegen/pom.xml, line 176, column 21
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.swagger:swagger-codegen-project:pom:2.1.6-SNAPSHOT
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-source-plugin @ line 176, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[ERROR] [ERROR] Could not find project to resume reactor build from: :RubyPetstoreClientTests vs [MavenProject: io.swagger:swagger-codegen-project:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/pom.xml, MavenProject: io.swagger:swagger-codegen:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen/pom.xml, MavenProject: io.swagger:swagger-codegen-cli:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen-cli/pom.xml, MavenProject: io.swagger:swagger-codegen-maven-plugin:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen-maven-plugin/pom.xml, MavenProject: io.swagger:swagger-generator:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-generator/pom.xml] @
[ERROR] Could not find project to resume reactor build from: :RubyPetstoreClientTests vs [MavenProject: io.swagger:swagger-codegen-project:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/pom.xml, MavenProject: io.swagger:swagger-codegen:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen/pom.xml, MavenProject: io.swagger:swagger-codegen-cli:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen-cli/pom.xml, MavenProject: io.swagger:swagger-codegen-maven-plugin:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen-maven-plugin/pom.xml, MavenProject: io.swagger:swagger-generator:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-generator/pom.xml] -> [Help 1]
org.apache.maven.MavenExecutionException: Could not find project to resume reactor build from: :RubyPetstoreClientTests vs [MavenProject: io.swagger:swagger-codegen-project:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/pom.xml, MavenProject: io.swagger:swagger-codegen:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen/pom.xml, MavenProject: io.swagger:swagger-codegen-cli:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen-cli/pom.xml, MavenProject: io.swagger:swagger-codegen-maven-plugin:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-codegen-maven-plugin/pom.xml, MavenProject: io.swagger:swagger-generator:2.1.6-SNAPSHOT @ /home/helge/code/swagger-codegen/modules/swagger-generator/pom.xml]
        at org.apache.maven.graph.DefaultGraphBuilder.trimResumedProjects(DefaultGraphBuilder.java:325)
        at org.apache.maven.graph.DefaultGraphBuilder.dependencyGraph(DefaultGraphBuilder.java:117)
        at org.apache.maven.graph.DefaultGraphBuilder.build(DefaultGraphBuilder.java:92)
        at org.apache.maven.DefaultMaven.buildGraph(DefaultMaven.java:491)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:219)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
[ERROR]
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException

@wing328
Copy link
Contributor

wing328 commented Jan 29, 2016

Please give it another try by running the command under the samples/client/petstore/ruby folder.

@tsujigiri
Copy link
Contributor Author

Ah, and of course they fail, because .present? is an extension from activesupport.

@tsujigiri
Don't force explicit configuration of CA cert location
f85f885 
In order to allow openssl to figure out the location of CA certificates
on its own, don't apply the `ssl_ca_cert` configuration parameter if it
is not explicitly set.
@tsujigiri
Copy link
Contributor Author

I removed the .present?. The tests pass.

wing328 added a commit that referenced this pull request Jan 29, 2016
@wing328
Merge pull request #2003 from ad2games/non-explicit-ca-info-config
f42f9ac 
Don't force explicit configuration of CA cert location
@wing328 wing328 merged commit f42f9ac into swagger-api:master Jan 29, 2016
@tsujigiri tsujigiri deleted the non-explicit-ca-info-config branch January 29, 2016 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: Ruby Enhancement: General
Projects
None yet
Milestone
v2.1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@tsujigiri @wing328