-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model's "additionalProperties" handling in python client #2058
Conversation
…ictionary handling in model's to_dict() method
@mtngld thanks for the PR. I notice the commits are not linked to your account, which means this PR won't count as your contribution towards https://github.com/swagger-api/swagger-codegen/graphs/contributors. If you're ok with that, we'll review and merge the PR later. |
Also not sure how hard it's but it would be nice to add a test case in the Python Petstore sample to cover the bug moving forward. |
Hi, hopefully I fixed my account linking issue, I have no problem adding a testcase, but currently |
You're right. I'll add a fake model later and would need your help to add a test case if you don't mind. I think you need to close this PR and open a new one. You can then check the "Commits" tab to confirm. |
I can see that it's fixed in the commit tab. will review and approve accordingly. |
@mtngld is the change compatible with python3.x? I ran the integration test as follows but got errors:
Let me know if you can't repeat the issue locally. |
and here is part of the error message if it helps:
|
Sorry about that, only tested on 2.7 Now fixed a small compatibility issue, |
Add model's "additionalProperties" handling in python client
@mtngld thanks and PR merged. I saw
I will create a task to track it and see if anyone from the community has cycle to update the code with assertRegex instead. |
@mtngld btw, one suggestion is to create a new branch instead fixing the issue in the master (I believe creating a new branch for change is part of the Git best practices) |
Hi, @wing328, sorry for all the bother I caused, but I found a bug in my PR, I made a new branch that:
Should I create a new PR? The new branch is based on the current master (which includes my previous PR), let me know if you want to simply revert the old PR and I will rebase to a clean and updated master. Sorry again and thank you for your patience and guidance We should definetly write test case for this scenario since that bug was not caught by |
Please submit a PR for the fix. William On Mon, Feb 8, 2016 at 3:56 AM, Matan Goldman notifications@github.com
|
Fix #2037 by adding dictionary handling in a model's
to_dict()
method