Correct exporting of enum classes #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delenius
force-pushed
the
enum-exports
branch
from
f5f78f3
to
11f44bb
Compare
delenius
force-pushed
the
enum-exports
branch
from
11f44bb
to
59931ef
Compare
|
@wing328 it should be fine now. |
wing328
added a commit
that referenced
this pull request
Feb 16, 2016
Correct exporting of enum classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2102.
This attaches the enum classes to the main model class. This also ensures that the enum is exported along with the model. There is no longer a need for a separate export of the enum.
The enums now looks similar to a local class in Java, which seems appropriate, since they are indeed local to the model class being defined.
Note: This conflicts with #2115
Take them in any order, and I'll rebase accordingly. We need both to really fix the enums, but the two PRs address two different issues.