Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git_push.sh and .gitignore to client generators #2366

Merged
merged 3 commits into from
Mar 12, 2016

Conversation

wing328
Copy link
Contributor

@wing328 wing328 commented Mar 12, 2016

Better integration with Github with git_push shell script and .gitignore file

@wing328 wing328 added this to the v2.1.6 milestone Mar 12, 2016
wing328 added a commit that referenced this pull request Mar 12, 2016
Add git_push.sh and .gitignore to client generators
@wing328 wing328 merged commit d3f26f7 into swagger-api:master Mar 12, 2016
@wing328 wing328 deleted the git_push_sh branch March 15, 2016 16:06
@ktunkiewicz
Copy link

@wing328 seriously? A bash script to use gihtub? And this is a breaking change for people using their own templates since there is no system property to avoid generation of this file.

We started using swagger-codegen in our company but watching the development process of this library I'll probably freeze the version that we use to 2.1.6 and bugfix things myself... The (breaking) (nonsense) feature added to milestone, PRed and merged, all in one day... Do anybody even discuss changes to that project? Why the hell the bash script to use github? It looks like a toy for beginner programmers who don't know how to use gihtub.

@ktunkiewicz
Copy link

ktunkiewicz commented Apr 29, 2016

Sorry for being a bit too agressive with that comment, I just got confused how many things broke down when I updated the swagger-codegen (i'm using custom templates so things usually break if something is changed in templates) and reacted too emotional.
The project is great anyways. Very helpful and working really good. Great job.
But you really should choose more carefully what to change/add to it since if somebody wants to use if for some serious project he will get confused with changes like this one...

@wing328
Copy link
Contributor Author

wing328 commented Apr 29, 2016

@ktunkiewicz personally I welcome both positive and negative feedback.

Did you have a chance to read the release note? Does it help making the migration smoother?

The git_push is to address a pain point we'd in uploading the auto-generated SDKs to Github for testing (e.g. import/install directly via git, CI integration, etc). I agree that it won't fit into every single workflow but we got to start with "something" to begin with and improve it based on the feedback from the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants