Use PHP's DateTime::ATOM for true ISO-8601 support #2385
Conversation
|
@arnested thanks for the PR. I don't see change in the object serializer mustache template. I only found changes to the PHP Petstore sample. Would you please take a look and rebase on the latest master? |
|
Yeah, I apparently got something wrong there. Rebasing and fixing right now. New push in a minute. Sorry for the trouble, @wing328. |
|
@arnested no worry. Please take your time. |
Currently we use PHP's DateTime::ISO8601 for the date-time properties but according to http://php.net/manual/en/class.datetime.php#datetime.constants.iso8601 it is actually not compatible with ISO-8601. Instead we should use DateTime::ATOM.
|
Just a minor glitch -- fixed and push now. |
| *UserApi* | [**loginUser**](docs/UserApi.md#loginuser) | **GET** /user/login | Logs user into the system | ||
| *UserApi* | [**logoutUser**](docs/UserApi.md#logoutuser) | **GET** /user/logout | Logs out current logged in user session | ||
| *UserApi* | [**updateUser**](docs/UserApi.md#updateuser) | **PUT** /user/{username} | Updated user | ||
| *PetApi* | [**addPet**](PetApi.md#) | **POST** /pet | Add a new pet to the store |
There was a problem hiding this comment.
Are you using a customized version of PhpClientCodegen and DefaultCodegen somehow? e.g. {{operationIdLowerCase}} seems not defined.
There was a problem hiding this comment.
After rebasing I forgot to mvn clean package so this was probably generated with an older / somehow other version of codegen.
I've rebuild codege, regenerated the petstore sample, and run the phpunit test suite now.
CI is currently building.
Sorry for the noise again and thank you for catching it.
Use PHP's DateTime::ATOM for true ISO-8601 support
|
Upgrade note from 2.1.5 to 2.1.6 Starting from 2.1.6,
Ref: http://php.net/manual/en/class.datetime.php#datetime.constants.iso8601 If this breaks your application after upgrade, please reply to let us know and we'll share a workaround. |
Currently we use PHP's
DateTime::ISO8601for the date-time properties but according to http://php.net/manual/en/class.datetime.php#datetime.constants.iso8601 it is actually not compatible with ISO-8601.Instead we should use
DateTime::ATOM.