Updates to objc api to address issue #2422 #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2016 10:56
…ttings for reachability status. This addresses "Default iOS reachability status swagger-api#2422"
|
@Stuart-campbell thanks for the PR. The change looks good to me and the test cases for ObjC Petstore passed. |
wing328
added a commit
that referenced
this pull request
Mar 22, 2016
Updates to objc api to address issue #2422
yaelah
pushed a commit
to yaelah/swagger-codegen
that referenced
this pull request
Apr 9, 2016
Updates to objc api to address issue swagger-api#2422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added getter for offline state this lets the app check if and ApiClient is going to attempt the network request or just force cache.
Added setter for AFNetworkReachabilityStatus, this is useful for two reason first to set the default before it has been set by the reachability manager.
Also as the ApiClient uses a shared instance of the reachability manager it is possible for another class to setReachabilityStatusChangeBlock stopping the ApiClient getting reachability change callbacks internally. By adding a setter it would be possible to pass the changes along.
Note: on changes to SWGName, these changes must be because the last person to edit the swagger spec did not regenerate the objc code.