Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#][aspnet] Deprecating aspnet5 for aspnetcore #4011

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

jimschubert
Copy link
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description

This moves previous aspnet5 functionality to aspnetcore, aspnet5 now
derives from the aspnetcore generator and logs a warning that it's
deprecated.

This will help resolve any confusion because ASP.NET 5 is terminology
referring to the project of around a year ago. ASP.NET Core 1.0 is the
new name for the technology, and further enhancements should target .NET
Core 1.0 rather than any old vNext or preview stuff.

See #3085

I ran the bash script, no code changed other than path renames.
This would be a breaking change if CI relies on the aspnet5 paths or files under ./bin (I didn't see any).

The aspnet5 generator still exists, and works as it did before... it just logs a warning now that you should use aspnetcore now.

If this gets merged, the Wiki at https://github.com/swagger-api/swagger-codegen/wiki/Server-stub-generator-HOWTO#aspnet-5-web-api should update from "ASP.NET 5 Web API" to "ASP.NET Core 1.0". I don't think "Web API" is a relevant term anymore. I'm pretty certain it's now considered "ASP.NET Core 1.0 MVC", but I think the MVC is pretty much implied now.

This moves previous aspnet5 functionality to aspnetcore, aspnet5 now
derives from the aspnetcore generator and logs a warning that it's
deprecated.

This will help resolve any confusion because ASP.NET 5 is terminology
referring to the project of around a year ago. ASP.NET Core 1.0 is the
new name for the technology, and further enhancements should target .NET
Core 1.0 rather than any old vNext or preview stuff.
@wing328
Copy link
Contributor

wing328 commented Oct 17, 2016

@jimschubert thanks for the PR. I've not setup any CI for aspnet5. I only setup appveyor to cover Petstore C# API client.

@wing328 wing328 merged commit 12bcb2d into swagger-api:master Oct 17, 2016
@wing328 wing328 changed the title [aspnetcore] Deprecating aspnet5 for aspnetcore [C#][aspnet] Deprecating aspnet5 for aspnetcore Feb 20, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
[aspnetcore] Deprecating aspnet5 for aspnetcore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants