Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#][Nancy] Add switch to toggle whether to use the api base path as the module path or not #4053

Merged
merged 4 commits into from
Oct 24, 2016

Conversation

simo9000
Copy link
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Added config switch for c# server (nancyfx) to allow user to toggle whether to use the api base path as the module path or not. It is necessary for some host configurations.

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

parser needs to access the Value parameter to enable the direct cast at line 102 when handling string parameters
@wing328 wing328 added this to the v2.2.2 milestone Oct 24, 2016
@wing328 wing328 merged commit 5855b47 into swagger-api:master Oct 24, 2016
acramatte added a commit to comerge/swagger-codegen that referenced this pull request Oct 25, 2016
* upstream/master: (43 commits)
  [Java] BeanValidation + JAXRS CXF server generator (swagger-api#4068)
  update JS petstore samples
  nancyfx basePath => modulePath toggle (swagger-api#4053)
  Throw an Error object instead of a string
  [Qt5/C++] Arrays of primitive types fix (swagger-api#4046)
  fix NancyFX string parser (swagger-api#4048)
  Fix sanitizeTag to retain numbers and underscore in tag names
  add test for java6 jersey2 client
  hashCode and equals support for jdk6 for jersey2 (swagger-api#4039)
  update gitignore to include PetStore.pro.user
  increase timeout value for qt5 petstore test
  update undertow readme
  Java6 support for jersey2 (swagger-api#4033)
  [java] Allow setting test folder
  fix reserved word handling in model name (sinatra)
  better handling of reserved words for sintatra, dart
  improvements based on swagger-api#3568 (swagger-api#4021)
  [csharp] add missing anchor tags in readme (swagger-api#4019)
  Issue 3651 (swagger-api#4014)
  Added company (swagger-api#4015)
  ...
simo9000 added a commit to simo9000/swagger-codegen that referenced this pull request Nov 1, 2016
* fix NancyFX string parser

parser needs to access the Value parameter to enable the direct cast at line 102 when handling string parameters

* Updated nancyfx sample

* Added switch to config to toggle use of yaml base path as module paths
@wing328 wing328 changed the title nancyfx basePath => modulePath toggle [C#][Nancy] Add switch to toggle whether to use the api base path as the module path or not Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants