Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesafe swagger-play 1.3.2 depends on swagger-core 1.3.1 #450

Closed
sheavner opened this issue Jan 29, 2014 · 4 comments
Closed

Typesafe swagger-play 1.3.2 depends on swagger-core 1.3.1 #450

sheavner opened this issue Jan 29, 2014 · 4 comments

Comments

@sheavner
Copy link

Was this intended? Why doesn't it use the 1.3.2 versions?

Requiring "com.wordnik" % "swagger-play2_2.10" % "1.3.2" pulls in http://repo.typesafe.com/typesafe/repo/com/wordnik/swagger-play2_2.10/1.3.2/swagger-play2_2.10-1.3.2.jar

swagger-annotations-1.3.1.jar
swagger-core_2.10-1.3.1.jar [16-Jan-2014]
swagger-jaxrs_2.10-1.3.1.jar
swagger-play2_2.10-1.3.2.jar [03-Dec-2013]

@fehguy
Copy link
Contributor

fehguy commented Jan 29, 2014

swagger-play2 got ahead by a version number. Will address this today.

@andyoll
Copy link

andyoll commented Jan 30, 2014

  • I think it's more likely a case that there doesn't seem to be a current
    plan to ensure all dependences are updated in all sub-projects
    simultaneously. Doing this would potentially slow down releases of Core,
    which is perhaps not so useful.

It would be interesting to hear Tony's thoughts on this - I think having
sub-projects in separate repo's might make sense if the various components
follow different release timelines. This would allow different version
numbering conventions, and branching strategies, to be used for the
sub-projects.

On 29 January 2014 21:03, sheavner notifications@github.com wrote:

Was this intended? Why doesn't it use the 1.3.2 versions?

Requiring "com.wordnik" % "swagger-play2_2.10" % "1.3.2" pulls in
http://repo.typesafe.com/typesafe/repo/com/wordnik/swagger-play2_2.10/1.3.2/swagger-play2_2.10-1.3.2.jar

swagger-annotations-1.3.1.jar
swagger-core_2.10-1.3.1.jar [16-Jan-2014]
swagger-jaxrs_2.10-1.3.1.jar
swagger-play2_2.10-1.3.2.jar [03-Dec-2013]

Reply to this email directly or view it on GitHubhttps://github.com//issues/450
.

@fehguy
Copy link
Contributor

fehguy commented Jan 30, 2014

It is easy enough to release them all at once--and given the pace of releases, it does make sense. The challenge has been that the main project is built with maven while the play module uses sbt. It's simply a workflow issue (on my part) which hasn't ensure they're all done at once.

I think the short term solution is to use a maven plugin to ensure the play2 module is built, which will keep it compiling. The tests in the play2 module need some love, and the deploy process needs to be more consistent.

There will be (hopefully) a time where they don't all update at once.

@fehguy
Copy link
Contributor

fehguy commented Feb 20, 2014

Hi, just released 1.3.3, so your dependencies should be updated as such:

"com.wordnik" %% "swagger-play2" % "1.3.3"

I'm going to get the versions back in sync by releasing swagger-core-1.3.4 next, skipping swagger-core-1.3.3.

@fehguy fehguy closed this as completed Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants